Skip to content

install: skip workspace members whose package.json has no name - #38781

Open
robobun wants to merge 4 commits into
mainfrom
farm/9db45ae9/skip-nameless-workspace-members
Open

install: skip workspace members whose package.json has no name#38781
robobun wants to merge 4 commits into
mainfrom
farm/9db45ae9/skip-nameless-workspace-members

install: skip workspace members whose package.json has no name

82be3bd
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Aug 15, 2026 in 13m 14s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit src/install/lockfile/Package/WorkspaceMap.rs:55-67 Duplicate 'Skipping workspace' warnings for overlapping workspaces entries

Annotations

Check warning on line 67 in src/install/lockfile/Package/WorkspaceMap.rs

See this annotation in the file changed.

@claude claude / Claude Code Review

Duplicate 'Skipping workspace' warnings for overlapping workspaces entries

`skipped_with_dependencies` is a plain `Vec` with an unconditional `push`, so a nameless-with-deps directory matched by more than one `workspaces` entry (e.g. `["packages/fixture", "packages/*"]`) is recorded once per match and `warn_skipped()` prints the same warning N times. Named workspaces in the same situation dedup by path via `insert()`'s `get_or_put`. Purely cosmetic — checking `self.skipped_with_dependencies.iter().any(|d| &**d == relative_dir)` before the push would align them.