bundler: fail the build when an entry point has no module to bundle - #38778
Open
robobun wants to merge 5 commits into
Open
bundler: fail the build when an entry point has no module to bundle#38778robobun wants to merge 5 commits into
robobun wants to merge 5 commits into
Claude / Claude Code Review
completed
Aug 15, 2026 in 16m 5s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/bundler/transpiler.rs:460-467 |
Too-long-path guard arm returns Err without logging, contradicting the new 'every failure is logged' contract |
Annotations
Check warning on line 467 in src/bundler/transpiler.rs
claude / Claude Code Review
Too-long-path guard arm returns Err without logging, contradicting the new 'every failure is logged' contract
The new doc comment states "Every failure is logged before it is returned", but the pre-existing guard arm just below (`top_level_dir.len() + entry_point.len() + 4 > MAX_PATH_BYTES`, lines 470-475) returns `Err(err)` without calling `add_error_fmt` — so a >~4090-byte entry-point specifier that fails to resolve is still silently dropped, the same bug class this PR closes. Consider logging before returning there too (mirroring the general `Err` arm at line 529), or at minimum softening the doc com
Loading