install: stamp lockfileVersion 1 on new bun.lock files - #38741
Open
robobun wants to merge 3 commits into
Open
Claude / Claude Code Review
completed
Aug 15, 2026 in 15m 59s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 1 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟣 Pre-existing | docs/pm/lockfile.mdx:59 |
BunLockFile type declaration missing lockfileVersion 3 |
Annotations
Check notice on line 59 in docs/pm/lockfile.mdx
claude / Claude Code Review
BunLockFile type declaration missing lockfileVersion 3
Pre-existing (not introduced by this PR): the public `BunLockFile` type in `packages/bun-types/bun.d.ts:9811` declares `lockfileVersion: 0 | 1 | 2` and `overrides?: Record<string, string>`, so it cannot represent the `lockfileVersion` 3 files this PR now documents at `docs/pm/lockfile.mdx:59` (v3's `overrides` values are objects, not strings). Worth a follow-up to add `| 3` and widen the `overrides` value type; not blocking here since V3 and object-valued overrides both predate this PR and it do
Loading