pack: skip bins reached through symlinks; publish: do not read the readme through a symlink - #38707
Open
robobun wants to merge 8 commits into
Open
pack: skip bins reached through symlinks; publish: do not read the readme through a symlink#38707robobun wants to merge 8 commits into
robobun wants to merge 8 commits into
Claude / Claude Code Review
completed
Aug 15, 2026 in 13m 59s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/cli/publish_command.rs:1592-1594 |
README skipped on filesystems that return DT_UNKNOWN |
Annotations
Check warning on line 1594 in src/runtime/cli/publish_command.rs
claude / Claude Code Review
README skipped on filesystems that return DT_UNKNOWN
Changing `== Directory` to `!= File` now also skips `EntryKind::Unknown`, which `DirIterator` returns on filesystems that don't populate `d_type` (NFS, some FUSE/overlayfs — see src/sys/lib.rs:274-276). Before, an Unknown README fell through to the filename check and was sent as `readme`/`readmeFilename`; now it is silently omitted. Since the intent is only to exclude symlinks, gate on `entry.kind == SymLink || entry.kind == Directory` (or lstatat on Unknown, per the robobun note about #38716's
Loading