-
Notifications
You must be signed in to change notification settings - Fork 5k
docs: add voice guidelines to the contributing page #38705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 The description says this section covers "how to preview them", but the landed text only says where the docs live — and commit ab635bc in this PR deletes the
## Development(Mintlifymint dev) block fromdocs/README.mdwithout mentioning it in the description, so contributors now have no documented way to preview docs locally. Either add (or point to) the replacement preview workflow here, or drop "how to preview them" from the description and mention the README## Developmentremoval so the squash message matches the diff.Extended reasoning...
What's mismatched
The PR description's Fix bullet says:
The section that actually landed at
contributing.mdx:383is one sentence:That covers where the docs live, but there is no preview workflow.
The unmentioned removal
At the same time, this PR's second commit — ab635bc "drop the Mintlify preview instructions; bun.com/docs has its own generator" — deletes the entire
## Developmentblock fromdocs/README.md:That block was the only documented local-preview workflow anywhere in the repo. The PR description says only "
docs/README.mdpoints at the section" — it doesn't mention the removal. The description was already updated once during review (see the resolved thread aboutlanding-prs.mdmoving to #38718), so keeping it accurate is clearly in scope.Why it matters (a little)
After merge, contributors have no documented way to preview docs locally, while:
.claude/docs/landing-prs.md:55(whichCLAUDE.mdtells docs authors to read) still instructs them to "preview rendered markdown (an unbalanced fence swallows everything after it)"docs/docs.json:2still declares"$schema": "https://mintlify.com/docs.json", so it isn't obvious to a contributor that Mintlify is no longer the way to previewSo the guidance says "preview before committing", the description says "this section tells you how", and the section doesn't. The commit message for ab635bc ("bun.com/docs has its own generator") confirms the removal was intentional, which makes the description's "how to preview them" claim doubly stale.
Per
.claude/docs/landing-prs.md(PR process): "The PR description is the permanent squash-commit message — keep it true" and "Every file in the diff must be explainable from the PR's stated purpose."Step-by-step
CLAUDE.md→ reads Docs, types, and comments in.claude/docs/landing-prs.md.docs/README.md— before this PR:bun install -g mint/mint dev/localhost:3000. After this PR: only a pointer tocontributing.mdx#voice.contributing.mdx§ Contributing to the docs — no preview instructions there either.docs/for "preview" / "mint" — onlydocs.json's Mintlify$schemaand an unrelated font-CDN URL remain, which is more confusing than nothing.Fix
Either of:
contributing.mdx§ Contributing to the docs (whatever replaced Mintlify — the ab635bc commit message says "bun.com/docs has its own generator", so presumably a command from that generator, or a note that there is no local preview and to check the deploy preview on the PR).docs/README.md's## Development(Mintlify) block was removed, so the squash-commit message matches what actually lands.Why this is only a nit
Nothing breaks at runtime — this is a docs/contributor-workflow gap plus a stale squash-message claim. The Voice section (the substance of this PR) lands correctly. The fix is a one-line description edit or a one-sentence addition to the new section.