install: name folder, tarball and git packages without a package.json name after their source - #38681
Open
robobun wants to merge 2 commits into
Open
install: name folder, tarball and git packages without a package.json name after their source#38681robobun wants to merge 2 commits into
robobun wants to merge 2 commits into
Claude / Claude Code Review
completed
Aug 14, 2026 in 14m 38s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/install/PackageManager/processDependencyList.rs:157-160 |
Incomplete Global::crash() → self.crash() migration in process_extracted_tarball_package |
Annotations
Check warning on line 160 in src/install/PackageManager/processDependencyList.rs
claude / Claude Code Review
Incomplete Global::crash() → self.crash() migration in process_extracted_tarball_package
The `Global::crash()` → `self.crash()` migration was applied to the Git/Github and LocalTarball/RemoteTarball arms but not the fallback `_` arm's `parse_package_json` error branch (line ~300), which also writes to `log`. Per REVIEW.md "Fix the whole class in the same PR … parallel switch arms", that third site should get the same treatment (and `Global` in the `use bun_core::{Global, Output};` import then becomes unused).
Loading