sql: fix the build after #32089 × #37275 (LISTEN/NOTIFY error path) - #38628
Merged
Claude / Claude Code Review
completed
Aug 14, 2026 in 8m 1s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/sql_jsc/postgres/PostgresSQLConnection.rs:3131-3132 |
Use crate helper js_error_to_postgres instead of hand-rolled JsError→AnyPostgresError mapping |
Annotations
Check warning on line 3132 in src/sql_jsc/postgres/PostgresSQLConnection.rs
claude / Claude Code Review
Use crate helper js_error_to_postgres instead of hand-rolled JsError→AnyPostgresError mapping
Use the crate's documented helper `.map_err(crate::jsc::js_error_to_postgres)?` instead of hand-rolling `|_| AnyPostgresError::JSError` (same at line 3108). Every other `JsResult → AnyPostgresError` site in this crate goes through that helper, and it preserves the `JsError::OutOfMemory → AnyPostgresError::OutOfMemory` mapping rather than collapsing both variants into `JSError`.
Loading