error: report default class constructor frames at the class definition - #38507
Open
robobun wants to merge 5 commits into
Open
error: report default class constructor frames at the class definition#38507robobun wants to merge 5 commits into
robobun wants to merge 5 commits into
Claude / Claude Code Review
completed
Aug 14, 2026 in 16m 9s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/test/stack.test.ts:259-261 |
Third subprocess test does not drain stdout pipe |
Annotations
Check warning on line 261 in test/js/bun/test/stack.test.ts
claude / Claude Code Review
Third subprocess test does not drain stdout pipe
This test leaves `stdout` at its default of `"pipe"` but only awaits `stderr` and `proc.exited`, leaving the stdout pipe undrained — the two sibling tests in this describe block correctly do `Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited])`. The fixture writes nothing to stdout so it can't deadlock in practice, but for consistency with REVIEW.md's drain-pipes-concurrently rule and the neighbors, either add `proc.stdout.text()` to the `Promise.all` or set `stdout: "ignore"`.
Loading