bundler: report a split dynamic import as its input file in the metafile - #38465
Open
robobun wants to merge 6 commits into
Open
bundler: report a split dynamic import as its input file in the metafile#38465robobun wants to merge 6 commits into
robobun wants to merge 6 commits into
Claude / Claude Code Review
completed
Aug 14, 2026 in 10m 38s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/bundler/metafile.test.ts:470-473 |
New subprocess tests pipe stdout but never drain it |
Annotations
Check warning on line 473 in test/bundler/metafile.test.ts
claude / Claude Code Review
New subprocess tests pipe stdout but never drain it
Both new CLI-spawning tests set `stdout: "pipe"` but only await `[proc.stderr.text(), proc.exited]`, leaving stdout undrained — REVIEW.md's "Subprocess tests: drain pipes concurrently" rule and every sibling test in this file require `Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited])`. Same issue in the `buildMetafile` helper here and in the new `--metafile-md` splitting test around line 1151; either add `proc.stdout.text()` to the `Promise.all` or drop `stdout: "pipe"`.
Loading