install: report ENAMETOOLONG for a --cwd value that does not fit the path buffer - #38375
Open
robobun wants to merge 5 commits into
Open
install: report ENAMETOOLONG for a --cwd value that does not fit the path buffer#38375robobun wants to merge 5 commits into
robobun wants to merge 5 commits into
Claude / Claude Code Review
completed
Aug 14, 2026 in 10m 10s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/cli/install/bun-install.test.ts:10323-10327 |
stdout piped but never drained |
Annotations
Check warning on line 10327 in test/cli/install/bun-install.test.ts
claude / Claude Code Review
stdout piped but never drained
The spawn call sets `stdout: "pipe"` but the `Promise.all` only awaits `proc.stderr.text()` and `proc.exited` — stdout is opened and never drained, contrary to REVIEW.md's "Subprocess tests: drain pipes concurrently" rule. There's no deadlock risk on this path (the child writes only to stderr and crashes before any install output), but the pipe is requested for no reason. Either add `proc.stdout.text()` to the `Promise.all`, or change to `stdout: "ignore"`.
Loading