s3: abort in-flight tasks at VM teardown by request id instead of reading task.http - #38353
Open
robobun wants to merge 1 commit into
Open
s3: abort in-flight tasks at VM teardown by request id instead of reading task.http#38353robobun wants to merge 1 commit into
robobun wants to merge 1 commit into
Claude / Claude Code Review
completed
Aug 14, 2026 in 15m 47s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/node/worker_threads/worker_threads.test.ts:2655-2658 |
Buffered S3 teardown test hangs to timeout if child exits before both requests land |
Annotations
Check warning on line 2658 in test/js/node/worker_threads/worker_threads.test.ts
claude / Claude Code Review
Buffered S3 teardown test hangs to timeout if child exits before both requests land
`await bothInFlight.promise` is only ever resolved from the server's `onResponded` callback — nothing wires the child's exit to reject it, so if the spawned child dies before both requests land (worker eval throws, S3Client init fails, subprocess crashes) the test hangs to the file timeout instead of failing fast. Consider racing it against `proc.exited`, e.g. `await Promise.race([bothInFlight.promise, proc.exited.then(c => Promise.reject(new Error('child exited early with ' + c)))])`. (Diagnost
Loading