error printer: keep async and <anonymous> frame names once error.stack has been read - #38327
Open
robobun wants to merge 4 commits into
Open
error printer: keep async and <anonymous> frame names once error.stack has been read#38327robobun wants to merge 4 commits into
robobun wants to merge 4 commits into
Claude / Claude Code Review
completed
Aug 14, 2026 in 9m 37s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/test/stack.test.ts:241-243 |
Subprocess test pipes stdout but never drains it |
Annotations
Check warning on line 243 in test/js/bun/test/stack.test.ts
claude / Claude Code Review
Subprocess test pipes stdout but never drains it
The test sets `stdout: "pipe"` but never reads `proc.stdout` — only `stderr` and `exited` are in the `Promise.all`. Per REVIEW.md's subprocess-test convention, either drop `stdout: "pipe"` or include `proc.stdout.text()` in the `Promise.all` and assert it is empty (the child writes nothing to stdout, so there is no deadlock risk here — this is just harness hygiene).
Loading