error printer: fix the code frame lines above errors thrown from vm/eval sources - #38244
Open
robobun wants to merge 4 commits into
Open
error printer: fix the code frame lines above errors thrown from vm/eval sources#38244robobun wants to merge 4 commits into
robobun wants to merge 4 commits into
Claude / Claude Code Review
completed
Aug 13, 2026 in 10m 56s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/node/vm/vm.test.ts:1571 |
uncaught error test pipes stdout but never drains it |
Annotations
Check warning on line 1571 in test/js/node/vm/vm.test.ts
claude / Claude Code Review
uncaught error test pipes stdout but never drains it
This test sets `stdout: "pipe"` but the `Promise.all` only drains `proc.stderr.text()` and `proc.exited` — stdout is never read. Every sibling subprocess test in this file drains all pipes concurrently per REVIEW.md; either add `proc.stdout.text()` to the `Promise.all` or drop `stdout: "pipe"`.
Loading