Skip to content

Remove dead code from the streams bindings, node:http, bun_sys, lsquic_sys, and orphaned files #38213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 13 commits into from
Aug 14, 2026
Merged

Remove dead code from the streams bindings, node:http, bun_sys, lsquic_sys, and orphaned files #38213

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
afd3a55
Remove dead streams/TextEncoder/KeyObject scaffolding and the unused …
robobun Aug 13, 2026
91784db
Remove dead bun_sys and lsquic_sys wrappers
robobun Aug 13, 2026
9f99e10
Remove dead spawn_sys and tcc_sys wrappers
robobun Aug 13, 2026
b95d607
Delete orphaned files: Zig-era misctools, stale ncrypto.patch, stray …
robobun Aug 13, 2026
f53cc50
node:http: remove the unreachable deprecated-reply ServerResponse path
robobun Aug 13, 2026
e183b85
source-lints: guard the symbols and files removed in this sweep
robobun Aug 13, 2026
e602c82
bun_sys: gate Tag::futimens to the platforms that still use it
robobun Aug 13, 2026
2c11b9e
spawn_sys: FdExt is only used on unix now
robobun Aug 13, 2026
0be40e1
[autofix.ci] apply automated fixes
autofix-ci[bot] Aug 13, 2026
abe40b4
streams: shorten the comments that mentioned the removed cross-realm …
robobun Aug 13, 2026
c1758fb
Keep TextEncoder.cpp and the cross-realm stream cell; trim the stubs …
robobun Aug 13, 2026
59bf369
Fix two doc comments that named removed functions; narrow the hawk.to…
robobun Aug 13, 2026
72cac7f
Delete test/internal/source-lints/dead-symbols-streams-http-misctools…
Jarred-Sumner Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .vscode/launch.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

48 changes: 0 additions & 48 deletions hawk.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,54 +452,6 @@ kind = "enum_variant"
level = "expect"
reason = "external code table: weak-ref type numbering shared with JSC"

[[override]]
lint = "hawk::dead_public"
crate = "bun_platform"
item = "darwin::Category::PointsOfInterest"
kind = "enum_variant"
level = "expect"
reason = "external code table: OSLog signpost category values"

[[override]]
lint = "hawk::dead_public"
crate = "bun_platform"
item = "darwin::Category::Dynamicity"
kind = "enum_variant"
level = "expect"
reason = "external code table: OSLog signpost category values"

[[override]]
lint = "hawk::dead_public"
crate = "bun_platform"
item = "darwin::Category::SizeAndThroughput"
kind = "enum_variant"
level = "expect"
reason = "external code table: OSLog signpost category values"

[[override]]
lint = "hawk::dead_public"
crate = "bun_platform"
item = "darwin::Category::TimeProfile"
kind = "enum_variant"
level = "expect"
reason = "external code table: OSLog signpost category values"

[[override]]
lint = "hawk::dead_public"
crate = "bun_platform"
item = "darwin::Category::SystemReporting"
kind = "enum_variant"
level = "expect"
reason = "external code table: OSLog signpost category values"

[[override]]
lint = "hawk::dead_public"
crate = "bun_platform"
item = "darwin::Category::UserCustom"
kind = "enum_variant"
level = "expect"
reason = "external code table: OSLog signpost category values"

[[override]]
Comment on lines 454 to 455

@claude claude Bot Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The PR description's Verification section still claims test/internal/source-lints/dead-symbols-streams-http-misctools.test.ts "pins everything above; all 40 content checks and 16 deleted-file checks fail against main and pass here", but tip commit 72cac7f deletes that file (added earlier in this PR, edited in 59bf369 for the hawk.toml regex nit, then removed with no stated reason). Dropping the guard is likely correct per REVIEW.md ("Do not add tests to check dead code stays dead"), so the fix is just to update the Verification section — and optionally note why this sweep omits a guard where the sibling dead-symbols-*.test.ts files kept theirs.

Extended reasoning...

What the issue is

The tip commit of this PR is:

72cac7fa Delete test/internal/source-lints/dead-symbols-streams-http-misctools.test.ts

That file was added in e183b85, edited in c1758fb and 59bf369 (the latter narrowed the hawk.toml regex from /bun_platform|darwin::Category::/ to /darwin::Category::/ in response to the now-resolved inline review on this hunk), and then deleted entirely in 72cac7f with a bare commit message and no explanation in the PR body. Because it was added and deleted within the same PR, the file does not appear in the net diff at all.

However, the PR description's Verification section still says:

test/internal/source-lints/dead-symbols-streams-http-misctools.test.ts pins everything above; all 40 content checks and 16 deleted-file checks fail against main and pass here.

And the robobun evidence block ("fails on main / passes on PR") shows that test running at commit 59bf369 — one commit before it was deleted. So both the Verification bullet and the evidence block now describe verification that no longer exists at tip.

Step-by-step proof

  1. git log -- test/internal/source-lints/dead-symbols-streams-http-misctools.test.ts shows: added e183b85 → edited c1758fb → edited 59bf369 → deleted 72cac7f (tip).
  2. ls test/internal/source-lints/ at tip: the file is absent, while dead-symbols-install-sql-bindings.test.ts and dead-symbols-pub-exports-sweep.test.ts (from earlier sweeps) remain.
  3. The PR description's Verification section (last bullet) and the robobun "fails on main" / "passes on PR" console blocks both name the deleted file and show it running at 59bf369d3.
  4. Commit 72cac7f's message is bare ("Delete test/internal/source-lints/...") with no rationale, and the PR body was not updated after that commit.

Why the deletion itself is probably fine

REVIEW.md's Code style section says explicitly: "Do not add tests to check dead code stays dead." The guard test was doing exactly that (regex-matching source files to prevent reintroduction of removed symbols), so a maintainer deleting it is consistent with current review guidance. The two sibling dead-symbols-*.test.ts files predate that guidance and are not necessarily precedent to follow. The dead-code removals themselves are already verified by the build succeeding, cargo check on all targets, and the functional test suites listed in the Verification section — the guard test was belt-and-suspenders, not load-bearing.

Why it's still worth a comment

  • The PR description is now factually incorrect about its own verification. A reviewer reading it would assume a 40-check + 16-deleted-file guard test exists and passed; it doesn't exist.
  • The resolved inline review on this file ("drop the bun_platform| half of the alternation") was addressed in 59bf369, but the entire file was then deleted in the very next commit — so the resolution is moot, and that's not obvious from the thread.
  • REVIEW.md also says "Every deletion needs a stated reason or replacement"; the deletion commit carries neither.

Impact

None at runtime — this is PR hygiene only. Nothing in the merged code would misbehave. Per the rubric, PR-description mismatches default to nit, and there is no indication the code (as opposed to the description) is wrong.

Fix

Update the PR description's Verification section to drop the last bullet about dead-symbols-streams-http-misctools.test.ts (and optionally the robobun evidence block, which is auto-generated and will refresh on the next push anyway). If the guard was dropped deliberately per the "do not add tests to check dead code stays dead" rule, a one-line note to that effect would explain the divergence from the two sibling dead-symbols-*.test.ts files that remain in the directory.

lint = "hawk::dead_public"
crate = "bun_runtime"
Expand Down
24 changes: 0 additions & 24 deletions meta.json
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions misctools/.gitignore
View file
Open in desktop

This file was deleted.

142 changes: 0 additions & 142 deletions misctools/gdb/std_gdb_pretty_printers.py
View file
Open in desktop

This file was deleted.

46 changes: 0 additions & 46 deletions misctools/mime.js
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions packages/bun-release/scripts/npm-exec.ts
View file
Open in desktop

This file was deleted.

51 changes: 0 additions & 51 deletions packages/bun-usockets/misc/gen_test_certs.sh
View file
Open in desktop

This file was deleted.

Binary file removed packages/bun-usockets/misc/layout.png
View file
Open in desktop
Binary file not shown.
Loading
Loading