Remove dead code from the streams bindings, node:http, bun_sys, lsquic_sys, and orphaned files - #38213
Merged
Jarred-Sumner merged 13 commits intoAug 14, 2026
Claude / Claude Code Review
completed
Aug 14, 2026 in 20m 22s
Code review found 2 potential issues
Found 3 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/bindings/webcore/JSTextEncoder.h:93-96 |
Orphaned #includes left after TextEncoder EncodeIntoResult removal |
| 🟡 Nit | hawk.toml:454-455 |
Guard test deleted at tip; PR description Verification section is now stale |
Annotations
Check warning on line 96 in src/jsc/bindings/webcore/JSTextEncoder.h
claude / Claude Code Review
Orphaned #includes left after TextEncoder EncodeIntoResult removal
Removing the `convertDictionary<EncodeIntoResult>`/`convertDictionaryToJS` declarations here leaves `#include "JSDOMConvertDictionary.h"` (JSTextEncoder.h:25) with no remaining users; likewise TextEncoder.cpp now contains only `return "utf-8"_s;` but still includes `<JavaScriptCore/GenericTypedArrayViewInlines.h>` and `<JavaScriptCore/JSCInlines.h>` (lines 28-29). The PR already dropped the analogous now-dead includes from TextEncoder.h in the same commit, so these three were just missed — heade
Check warning on line 455 in hawk.toml
claude / Claude Code Review
Guard test deleted at tip; PR description Verification section is now stale
The PR description's Verification section still claims `test/internal/source-lints/dead-symbols-streams-http-misctools.test.ts` "pins everything above; all 40 content checks and 16 deleted-file checks fail against main and pass here", but tip commit 72cac7fa deletes that file (added earlier in this PR, edited in 59bf369d for the hawk.toml regex nit, then removed with no stated reason). Dropping the guard is likely correct per REVIEW.md ("Do not add tests to check dead code stays dead"), so the f
Loading