Skip to content

test(require-cache): skip the leak fixtures under debug builds #38148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −4
Open

test(require-cache): skip the leak fixtures under debug builds #38148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions test/cli/run/require-cache.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
isASAN,
isBroken,
isCI,
isDebug,
isIntelMacOS,
isMacOS,
isMusl,
Expand Down Expand Up @@ -50,7 +51,14 @@ describe.concurrent("require.cache", () => {
expect(exitCode).toBe(0);
});

describe.skipIf(isBroken && isIntelMacOS)("files transpiled and loaded don't leak the output source code", () => {
// The three "don't leak" blocks below are skipped under a debug build (bun bd): one
// load of their larger modules takes 1-7 s there, so every fixture overruns its
// timeout, and since the tests are concurrent, bun test does not kill the timed-out
// children, which run on for up to half an hour holding the inherited stdio. ASAN's
// quarantine also makes their RSS bounds meaningless. CI has no debug lane; the
// release and release+ASAN lanes (isDebug is false on both) still run them.
const skipSourceLeakChecks = isDebug || (isBroken && isIntelMacOS);
describe.skipIf(skipSourceLeakChecks)("files transpiled and loaded don't leak the output source code", () => {
test("via require() with a lot of long export names", async () => {
let text = "";
for (let i = 0; i < 10000; i++) {
Expand Down Expand Up @@ -281,7 +289,7 @@ describe.concurrent("require.cache", () => {
); // takes 4s on an M1 in release build
});

describe("files transpiled and loaded don't leak the AST", () => {
describe.skipIf(isDebug)("files transpiled and loaded don't leak the AST", () => {
test("via require()", async () => {
await using proc = Bun.spawn({
cmd: [bunExe(), "run", join(import.meta.dir, "require-cache-bug-leak-fixture.js")],
Expand Down Expand Up @@ -309,8 +317,7 @@ describe.concurrent("require.cache", () => {
}, 20000);
});

// These tests are extra slow in debug builds
describe("files transpiled and loaded don't leak file paths", () => {
describe.skipIf(isDebug)("files transpiled and loaded don't leak file paths", () => {
test("via require()", async () => {
await using proc = Bun.spawn({
cmd: [bunExe(), "--smol", "run", join(import.meta.dir, "cjs-fixture-leak-small.js")],
Expand Down
Loading