shell(cat): finish after a read error instead of cancelling the queued output and hanging - #37743
Open
robobun wants to merge 8 commits into
Open
shell(cat): finish after a read error instead of cancelling the queued output and hanging#37743robobun wants to merge 8 commits into
robobun wants to merge 8 commits into
Claude / Claude Code Review
completed
Aug 12, 2026 in 15m 56s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/shell/commands/cat.test.ts:48-53 |
openpty dlopen'd from libc.so.6 fails on glibc < 2.34 |
Annotations
Check warning on line 53 in test/js/bun/shell/commands/cat.test.ts
claude / Claude Code Review
openpty dlopen'd from libc.so.6 fails on glibc < 2.34
`libcPathForDlopen()` returns `"libc.so.6"` on glibc, but `openpty` only lives there since glibc 2.34 — before that it's in `libutil.so.1`, so on an older-glibc Linux runner these two `test.skipIf(!isLinux)` pty tests will throw "symbol not found" at dlopen time rather than skip. Every other test in the repo that FFI-calls `openpty` on glibc loads it from `"libutil.so.1"` (terminal-spawn.test.ts:335, no-orphans.test.ts:646, update_interactive_formatting.test.ts:166, all commented "glibc splits o
Loading