node:http: deliver all request headers on HTTP/1 fallback connections and enforce requireHostHeader - #37735
Open
robobun wants to merge 9 commits into
Open
node:http: deliver all request headers on HTTP/1 fallback connections and enforce requireHostHeader#37735robobun wants to merge 9 commits into
robobun wants to merge 9 commits into
Claude / Claude Code Review
completed
Aug 12, 2026 in 28m 14s
Code review found 1 important issue
Found 1 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | src/js/internal/http1_server_fallback.ts:402 |
Trailer line violates bun/no-duplicate-conditional-property-access, breaking CI lint test |
Annotations
Check failure on line 402 in src/js/internal/http1_server_fallback.ts
claude / Claude Code Review
Trailer line violates bun/no-duplicate-conditional-property-access, breaking CI lint test
This line reads `trailers.length` in the `if` test and again as a call argument, which trips `bun/no-duplicate-conditional-property-access` (enabled as `error` for `src/js/**` in `oxlint.json`, and this file is not in `ignorePatterns`). That makes `test/internal/oxlint-plugin-bun.test.ts`'s "bun run lint is clean on src/js" test fail — the `code 1` failures on 5 lanes in build #93589. Cache the length in a local (`const trailersLength = trailers.length`) as `_http_common`'s own `parserOnMessageC
Loading