Skip to content

Set error code EADDRINUSE in case conflict port, closes #3767 - #3770

Closed
hyuzea wants to merge 2 commits into
oven-sh:mainfrom
hyuzea:node-http-port-conflict
Closed

Set error code EADDRINUSE in case conflict port, closes #3767#3770
hyuzea wants to merge 2 commits into
oven-sh:mainfrom
hyuzea:node-http-port-conflict

Conversation

@hyuzea

@hyuzea hyuzea commented Jul 23, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

thank you for this, but it should be done in the native code instead of in node:http

@shivak

shivak commented Aug 7, 2023

Copy link
Copy Markdown

@Jarred-Sumner what is the desired behavior? I think the clearest approach would be to just turn off SO_REUSEPORT when Bun listens. In development, that flag is a foot gun. In production with load balancing, a parent watchdog process should be used to manage the port and workers.

I can just turn off the flag as part of #2852 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants