serve: build request.url through one function on every transport - #37635
Open
alii wants to merge 14 commits into
Open
serve: build request.url through one function on every transport#37635alii wants to merge 14 commits into
alii wants to merge 14 commits into
Claude / Claude Code Review
completed
Aug 15, 2026 in 12m 49s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/webcore/Request.rs:873 |
is_valid_host_header no longer needs pub(crate) visibility |
Annotations
Check warning on line 873 in src/runtime/webcore/Request.rs
claude / Claude Code Review
is_valid_host_header no longer needs pub(crate) visibility
Nit: `is_valid_host_header` no longer needs `pub(crate)` — this PR deletes its only external caller (the `.filter(|host| Request::is_valid_host_header(host))` block in `server_body.rs`), leaving only the `Self::` call inside `url_parts` in the same `impl` block. Per REVIEW.md ("Public items escape dead-code lints — grep for callers manually"), tighten it to a private `fn` in the same PR that removed the last cross-module use.
Loading