Error.prepareStackTrace: index source URLs by visible frame, not by JSC frame - #37450
Merged
Jarred-Sumner merged 4 commits intoAug 17, 2026
Merged
Claude / Claude Code Review
completed
Aug 11, 2026 in 11m 48s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/bindings/ErrorStackTrace.h:179-181 |
getStackTraceForThrownValue not removed as PR description states |
Annotations
Check warning on line 181 in src/jsc/bindings/ErrorStackTrace.h
claude / Claude Code Review
getStackTraceForThrownValue not removed as PR description states
The PR description says `JSCStackTrace::getStackTraceForThrownValue` "is removed instead of being adapted to the new signature", but the definition (ErrorStackTrace.cpp:185), the declaration here, and its ~15-line doc comment are still in the tree. A repo-wide grep confirms zero callers, so please follow through and delete all three — leaving it around now that `JSCStackFrame` holds a raw pointer into the source vector is a latent lifetime footgun for whoever wires up a caller later.
Loading