Skip to content

streams: remove NetworkSink's write-only cancel flag and unreachable EOF branch #37407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 1 commit into from
Aug 11, 2026
+1 −13
Merged

streams: remove NetworkSink's write-only cancel flag and unreachable EOF branch #37407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions src/runtime/webcore/streams.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2186,7 +2186,6 @@ pub struct NetworkSink {
pub(crate) upstream_error: jsc::strong::Optional,
pub(crate) ended: bool,
pub(crate) done: bool,
pub(crate) cancel: bool,
}

impl Default for NetworkSink {
Expand All @@ -2202,7 +2201,6 @@ impl Default for NetworkSink {
upstream_error: jsc::strong::Optional::empty(),
ended: false,
done: false,
cancel: false,
}
}
}
Expand Down Expand Up @@ -2336,7 +2334,6 @@ impl NetworkSink {
self.pending.result = Writable::Done;
self.pending.run();
self.source.close(None);
self.cancel = true;
self.finalize();
}

Expand Down Expand Up @@ -2522,16 +2519,7 @@ impl NetworkSink {
if self.task.is_some() && !self.done {
// we need to wait for the task to end
self.end_promise = JSPromiseStrong::init(self.global_this());
let value = self.end_promise.value();
if !self.ended {
self.ended = true;
// we need to send EOF
if let Some(task) = self.task_ref() {
let _ = task.write_bytes(b"", true);
}
self.source.close(None);
}
return bun_sys::Result::Ok(value);
return bun_sys::Result::Ok(self.end_promise.value());
}
// task already detached
bun_sys::Result::Ok(JSValue::js_number(0.0))
Expand Down