test(worker): keep the terminate() race tests under the default per-test timeout on debug builds - #37374
Open
robobun wants to merge 3 commits into
Open
test(worker): keep the terminate() race tests under the default per-test timeout on debug builds#37374robobun wants to merge 3 commits into
robobun wants to merge 3 commits into
Claude / Claude Code Review
completed
Aug 11, 2026 in 7m 24s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/web/workers/worker.test.ts:384-385 |
PR description is stale after the second commit |
Annotations
Check warning on line 385 in test/js/web/workers/worker.test.ts
claude / Claude Code Review
PR description is stale after the second commit
The PR description was written for commit e0752663 and says the entry-resolution and natural-exit tests "are left as they are" and that the readFile churn runs "10 workers... in two batches of 5" — but commit af4c0c78 then gates both of those tests on `isDebug` and restructures the readFile churn to `isDebug ? 1 : 5` batches of 10. Since the description becomes the squash-commit message, it'd be worth re-syncing it before merge (the second commit's message already covers what changed).
Loading