Skip to content

Bump WebKit to 3997b59485da - #37352

Merged
Jarred-Sumner merged 9 commits into
mainfrom
ali/bump-webkit-723cea6c
Aug 11, 2026
Merged

Bump WebKit to 3997b59485da#37352
Jarred-Sumner merged 9 commits into
mainfrom
ali/bump-webkit-723cea6c

add isolate breakpoint test

53a270d
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Aug 10, 2026 in 10m 28s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit test/cli/inspect/debugger-buntranspiledmodule.test.ts:9-19 Stale skipIf justification: expectations.txt entry does not exist

Annotations

Check warning on line 19 in test/cli/inspect/debugger-buntranspiledmodule.test.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Stale skipIf justification: expectations.txt entry does not exist

The comment justifying `skipIf(isCI && isASAN)` points readers at "`[ASAN] [TIMEOUT]` in test/expectations.txt" for inspect.test.ts (lines 10 and 15), but no such entry exists — inspect.test.ts is actually in `test/no-validate-exceptions.txt`, whose comment says it was moved there *so the whole file runs on ASAN* (just without validateExceptionChecks). Per REVIEW.md every skip needs a comment with the observed failure; either point at the real quarantine location/reason or drop the `skipIf(isCI