install: make the debug-build stack dump on package install failure opt-in - #37335
Open
robobun wants to merge 5 commits into
Open
install: make the debug-build stack dump on package install failure opt-in#37335robobun wants to merge 5 commits into
robobun wants to merge 5 commits into
Claude / Claude Code Review
completed
Aug 11, 2026 in 11m 16s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/cli/install/bun-link.test.ts:461-463 |
Test comment narrates the change and exceeds one line |
Annotations
Check warning on line 463 in test/cli/install/bun-link.test.ts
claude / Claude Code Review
Test comment narrates the change and exceeds one line
This 3-line comment opens with "Debug builds used to…" — past-tense change narration, which REVIEW.md's code-style section prohibits ("Only comment what the code cannot say. One line. Never narrate the change."). The comment-cop bot already flagged the Rust half of this PR for the same reason and it was trimmed to one line in b3dded3; this test-side comment was missed. The load-bearing content fits in one present-tense line, e.g. `// Exact match: the debug-only trace (stdout via llvm-symbolizer
Loading