fix(inspect): don't keep enumerating properties with an exception pending - #37330
Closed
robobun wants to merge 1 commit into
Closed
fix(inspect): don't keep enumerating properties with an exception pending#37330robobun wants to merge 1 commit into
robobun wants to merge 1 commit into
Claude / Claude Code Review
completed
Aug 10, 2026 in 20m 19s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/bindings/bindings.cpp:5675-5680 |
Same getPrototype().getObject() pattern remains at napi.cpp:2072 |
Annotations
Check warning on line 5680 in src/jsc/bindings/bindings.cpp
claude / Claude Code Review
Same getPrototype().getObject() pattern remains at napi.cpp:2072
nit: The same `->getPrototype(globalObject).getObject()` pattern remains at `src/jsc/bindings/napi.cpp:2072` (in `napi_get_all_property_names`'s filter loop, with no exception check after `getOwnPropertyDescriptor`) — a Proxy prototype whose trap throws produces the same segfault-at-0x5. It's the sole greppable sibling of this pattern in `src/`; pre-existing N-API code so non-blocking, but per REVIEW.md's "grep for every sibling site" it may be worth including the one-line fix here or noting it'
Loading