Fix debug assertion crashes when lazy Bun properties throw during property enumeration - #37307
Closed
robobun wants to merge 3 commits into
Closed
Fix debug assertion crashes when lazy Bun properties throw during property enumeration#37307robobun wants to merge 3 commits into
robobun wants to merge 3 commits into
Claude / Claude Code Review
completed
Aug 10, 2026 in 12m 45s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/util/inspect.test.js:594-597 |
Test pipes stderr but never drains it |
Annotations
Check warning on line 597 in test/js/bun/util/inspect.test.js
claude / Claude Code Review
Test pipes stderr but never drains it
The test sets `stderr: "pipe"` but never drains it — `Promise.all` only reads stdout and awaits `proc.exited`. Per REVIEW.md's "Subprocess tests: drain pipes concurrently" rule (and the immediately-preceding test at line 573), this should be `const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited])` followed by `expect({ stdout, stderr, exitCode }).toEqual({ stdout: "ok\n", stderr: "", exitCode: 0 })`.
Loading