resolver: lock DirEntry map probes against the in-place stale-generation rewrite - #37274
Merged
Merged
Claude / Claude Code Review
completed
Aug 9, 2026 in 32m 10s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/resolver/resolver.rs:3952-3957 |
probe_wildcard_extensions: node_modules gate switched from path substring to DirInfo flags |
Annotations
Check warning on line 3957 in src/resolver/resolver.rs
claude / Claude Code Review
probe_wildcard_extensions: node_modules gate switched from path substring to DirInfo flags
nit: to drop the `entries` param, this `.mjs → .mts` gate was rewritten from `!strings::path_contains_node_modules_folder(entries.dir)` to `!(resolved_dir_info.is_node_modules() || resolved_dir_info.is_inside_node_modules())`, but the sibling site this block is documented as mirroring ("same rewrite as `load_as_file`", :3948) still uses `path_contains_node_modules_folder(path)` at :5988-5989 — so the two gates now use different detection logic. `resolved_dir_info.abs_path` is equivalent to the o
Loading