process: don't run the uncaught-exception machinery from inside a lazy property lookup - #37258
Closed
robobun wants to merge 6 commits into
Closed
process: don't run the uncaught-exception machinery from inside a lazy property lookup#37258robobun wants to merge 6 commits into
robobun wants to merge 6 commits into
Claude / Claude Code Review
completed
Aug 9, 2026 in 13m 39s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/bindings/ZigGlobalObject.cpp:2552-2554 |
Bun.env lazy builder is a same-class site not covered by the fix |
Annotations
Check warning on line 2554 in src/jsc/bindings/ZigGlobalObject.cpp
claude / Claude Code Review
Bun.env lazy builder is a same-class site not covered by the fix
The `Bun.env` lazy builder (`constructEnvObject` at src/jsc/bindings/BunObject.cpp:108-111) is a sibling PropertyCallback that also calls `processEnvObject()` but has no exception scope, so on Windows with a clobbered `Proxy` and `Bun.env` accessed first it now returns into `reifyStaticProperty` with the exception still pending. Not a regression (was a hard crash on `LazyProperty::set(nullptr)` before), but per REVIEW.md's "fix the whole class" rule it should get the same clear + `reportLazyProp
Loading