Check base64 output length before encoding and cover btoa, StringDecoder at the 2 GiB string limit - #37235
Open
robobun wants to merge 4 commits into
Open
Check base64 output length before encoding and cover btoa, StringDecoder at the 2 GiB string limit#37235robobun wants to merge 4 commits into
robobun wants to merge 4 commits into
Claude / Claude Code Review
completed
Aug 9, 2026 in 9m 6s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/web/util/atob.test.js:78-79 |
Unconditional 90s timeout diverges from sibling test and cited pattern |
Annotations
Check warning on line 79 in test/js/web/util/atob.test.js
claude / Claude Code Review
Unconditional 90s timeout diverges from sibling test and cited pattern
nit: The comment says "slow under debug/ASAN" but `timeout = 90_000` is applied unconditionally, while the sibling change in `string-decoder.test.js` in this same PR gates it as `isDebug || isASAN ? 60_000 : undefined` and the cited `blob-oom.test.ts` pattern sets no timeout at all. Consider importing `isDebug`/`isASAN` from harness and gating this the same way (a higher value than 60s is fine given the second test actually completes a full 2 GiB encode).
Loading