Fix assertion failure when inspecting an object whose lazy property initializer throws - #37234
Closed
robobun wants to merge 2 commits into
Closed
Fix assertion failure when inspecting an object whose lazy property initializer throws#37234robobun wants to merge 2 commits into
robobun wants to merge 2 commits into
Claude / Claude Code Review
completed
Aug 9, 2026 in 10m 3s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/util/inspect.test.js:950 |
New subprocess tests pipe stderr but never drain it |
Annotations
Check warning on line 950 in test/js/bun/util/inspect.test.js
claude / Claude Code Review
New subprocess tests pipe stderr but never drain it
Both new subprocess tests set `stderr: "pipe"` but never drain it — only `proc.stdout.text()` and `proc.exited` are awaited. REVIEW.md's "Subprocess tests: drain pipes concurrently" rule and the neighboring tests in this file both call for `Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited])`; add `proc.stderr.text()` here and at line 978, or drop `stderr: "pipe"`.
Loading