Remove dead code from shell, bake dev server, sql, install, cli, css, and websocket client - #37229
Merged
Jarred-Sumner merged 8 commits intoAug 11, 2026
Claude / Claude Code Review
completed
Aug 11, 2026 in 11m 18s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/node/node_fs_watcher.rs:343 |
C++ DOMEventName mirror not pruned alongside Rust EventType::Abort removal |
Annotations
Check warning on line 343 in src/runtime/node/node_fs_watcher.rs
claude / Claude Code Review
C++ DOMEventName mirror not pruned alongside Rust EventType::Abort removal
The C++ mirror of this enum still declares the removed variant: `EventNames.cpp:50` (`abort = 3,`) and its switch arm at `EventNames.cpp:65-66`. `Bun__domEventNameToJS`'s only caller is `node_fs_watcher.rs:348` passing this Rust `EventType`, so `DOMEventName` is a 1:1 FFI mirror — the same half-prune pattern flagged for WebSocket `ErrorCode`/`WebSocketErrorCode` and fixed in b2ce4d9. Nothing breaks (`Close = 4` keeps its explicit discriminant on both sides); flagging for consistency with that fi
Loading