test(napi): check the experimental-finalizer wrapper's output before its exit code - #37214
Closed
dylan-conway wants to merge 34 commits into
Closed
test(napi): check the experimental-finalizer wrapper's output before its exit code#37214dylan-conway wants to merge 34 commits into
dylan-conway wants to merge 34 commits into
Claude / Claude Code Review
completed
Aug 9, 2026 in 17m 0s
Code review found 1 important issue
Found 2 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | src/jsc/bindings/ZigGlobalObject.cpp:3408-3428 |
Dl_info/dladdr unguarded in bunNapiDiagWhereAreTheRoots — Windows build-cpp still red |
Annotations
Check failure on line 3428 in src/jsc/bindings/ZigGlobalObject.cpp
claude / Claude Code Review
Dl_info/dladdr unguarded in bunNapiDiagWhereAreTheRoots — Windows build-cpp still red
Commit 85de86af added section 4' (native fp-chain) to `bunNapiDiagWhereAreTheRoots`, which uses `Dl_info`/`dladdr()` at lines 3423-3424 with no platform guard — but `<dlfcn.h>` is included only under `#if !OS(WINDOWS)` (lines 241-243), so on Windows these are undeclared identifiers and the TU fails to compile (robobun confirms 🪟 x64/aarch64 build-cpp are still red on bb4430b5). This is the same class as the earlier `<unistd.h>` break fixed in b8743eaf92; wrap the `bunNapiDiagWhereAreTheRoots` bo
Loading