test(fetch-leak): keep the RSS leak thresholds clear of measurement noise - #37209
Open
dylan-conway wants to merge 5 commits into
Open
test(fetch-leak): keep the RSS leak thresholds clear of measurement noise#37209dylan-conway wants to merge 5 commits into
dylan-conway wants to merge 5 commits into
Claude / Claude Code Review
completed
Aug 8, 2026 in 13m 14s
Code review found 1 important issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | test/js/web/fetch/fetch-leak.test.ts:755-761 |
readable-stream ASAN allowance (64 MiB) exceeds the ~32 MiB leak signal |
Annotations
Check failure on line 761 in test/js/web/fetch/fetch-leak.test.ts
claude / Claude Code Review
readable-stream ASAN allowance (64 MiB) exceeds the ~32 MiB leak signal
The ASAN branch here is still `"64"`, but the new comment two lines up computes the guarded regression's signal as ~32 MiB — so under `bun-asan` the reintroduced #23697 leak (~36-40 MiB with the capped quarantine) would pass this check. This is the same class as the HiveRef 320 > 256 threshold this PR just fixed in 23d51ac; the ASAN allowance here should also sit below its 32 MiB signal (e.g. `isASAN ? "24" : "20"`, or drop the branch since quarantine is already capped).
Loading