test(fetch-leak): keep the RSS leak thresholds clear of measurement noise - #37209
Open
dylan-conway wants to merge 5 commits into
Open
test(fetch-leak): keep the RSS leak thresholds clear of measurement noise#37209dylan-conway wants to merge 5 commits into
dylan-conway wants to merge 5 commits into
Claude / Claude Code Review
completed
Aug 8, 2026 in 6m 32s
Code review found 1 important issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | test/js/web/fetch/fetch-leak.test.ts:715 |
ASAN threshold now exceeds the leak signal after body size reduction |
Annotations
Check failure on line 715 in test/js/web/fetch/fetch-leak.test.ts
claude / Claude Code Review
ASAN threshold now exceeds the leak signal after body size reduction
The ASAN threshold here is still 320 MiB, but shrinking the body to 16 KiB dropped the guarded leak signal to ~256 MiB (per the updated comment two lines up) — so under `bun-asan` a real "deinit() skipped" regression would now pass this check. Either scale the ASAN bound down alongside the body size, or cap `quarantine_size_mb` in the child's `ASAN_OPTIONS` (as the neighboring tests in this file do) so a tighter bound holds.
Loading