s3: parse S3's XML responses with the XML parser instead of substring scraping - #37194
Merged
Claude / Claude Code Review
completed
Aug 8, 2026 in 16m 40s
Code review found 2 potential issues
Found 1 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/webcore/s3/xml_response.rs:99 |
PR description is stale: claims RecycledArena sharing that was reverted |
Annotations
Check warning on line 99 in src/runtime/webcore/s3/xml_response.rs
claude / Claude Code Review
PR description is stale: claims RecycledArena sharing that was reverted
The PR description's "Also folded in" paragraph still claims *"the per-thread recycled parse arena is factored out … as `RecycledArena` and shared with the S3 path (no `mi_heap` per response)"*, but that change was backed out in 0139df7 — `xml_response::parse` now does `let arena = bun_alloc::Arena::default();` (a fresh arena per call) and `src/runtime/api.rs` is not in the diff. Drop the `RecycledArena` clause; the second half of that sentence (moving `xml_parse_inc` to the API entry points) is
Loading