url: reject special-scheme hosts made only of IDNA-ignored code points - #37167
Closed
robobun wants to merge 8 commits into
Closed
url: reject special-scheme hosts made only of IDNA-ignored code points#37167robobun wants to merge 8 commits into
robobun wants to merge 8 commits into
Claude / Claude Code Review
completed
Aug 8, 2026 in 9m 20s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/web/url/url.test.ts:176-186 |
Bare toThrow() without asserting error code |
Annotations
Check warning on line 186 in test/js/web/url/url.test.ts
claude / Claude Code Review
Bare toThrow() without asserting error code
The bare `.toThrow()` calls at lines 177, 181, 184, and 186 should assert the specific error code — e.g. `toThrow(expect.objectContaining({ code: "ERR_INVALID_URL" }))` — matching the pattern already used in the "URL throws" test at the top of this file. REVIEW.md: "specific error class/code/message (never bare `toThrow()`)".
Loading