Fix stale exception when a lazy property initializer throws during property enumeration - #37158
Closed
robobun wants to merge 1 commit into
Closed
Fix stale exception when a lazy property initializer throws during property enumeration#37158robobun wants to merge 1 commit into
robobun wants to merge 1 commit into
Claude / Claude Code Review
completed
Aug 7, 2026 in 13m 26s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/util/inspect.test.js:828-830 |
Subprocess test pipes stderr but never drains it |
Annotations
Check warning on line 830 in test/js/bun/util/inspect.test.js
claude / Claude Code Review
Subprocess test pipes stderr but never drains it
The test sets `stderr: "pipe"` but never drains it — only `proc.stdout.text()` and `proc.exited` are awaited. Match the neighboring "huge sparse array" test and REVIEW.md's subprocess rule: `const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited])`, then assert the combined `{ stdout: stdout.trim(), stderr, exitCode }` object. Otherwise a regression that reintroduces the debug abort will show only `received ""` with the stderr backtrace silently
Loading