install: re-clone git dependency cache folders left incomplete by a killed install - #37145
Closed
robobun wants to merge 8 commits into
Closed
install: re-clone git dependency cache folders left incomplete by a killed install#37145robobun wants to merge 8 commits into
robobun wants to merge 8 commits into
Claude / Claude Code Review
completed
Aug 7, 2026 in 26m 15s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/install/PackageInstall.rs:2353-2363 |
Patched git dep: base-folder check in package_missing_from_cache still trusts bare directory |
Annotations
Check warning on line 2363 in src/install/PackageInstall.rs
claude / Claude Code Review
Patched git dep: base-folder check in package_missing_from_cache still trusts bare directory
The `patch.is_some()` branch of `package_missing_from_cache` (line 2386) still checks the stripped `@G@<sha>` base folder via `directory_exists_at`, without the `.bun-tag` check. For a **patched** git dependency with a poisoned base folder, this branch overrides the preinstall state to `Done`, `enqueue_git_for_checkout` is skipped, and the patch task copies the empty base folder — the same empty-package symptom this PR fixes elsewhere. This branch should mirror the `non_patched_path` fix already
Loading