install: reuse lockfile-resolved git packages for branch and bare refs when re-resolving - #37143
Open
robobun wants to merge 11 commits into
Open
install: reuse lockfile-resolved git packages for branch and bare refs when re-resolving#37143robobun wants to merge 11 commits into
robobun wants to merge 11 commits into
Claude / Claude Code Review
completed
Aug 7, 2026 in 34m 15s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/cli/install/bun-lock.test.ts:1188-1204 |
Duplicated gitEnv/git() helper setup between the two new tests |
Annotations
Check warning on line 1204 in test/cli/install/bun-lock.test.ts
claude / Claude Code Review
Duplicated gitEnv/git() helper setup between the two new tests
nit: the `gitEnv` object, the `async function git(args, cwd)` helper, and the `gitconfig` write are duplicated verbatim between this test and the one above it. A file-scope `makeGitHelper(packageDir)` factory returning `{ gitEnv, git }` (alongside the existing `makeInstallRunner`/`makeTarball` helpers) would deduplicate both and keep the git-config-isolation logic in one place.
Loading