install: reuse lockfile-resolved git/github/tarball packages when re-resolving - #37142
Open
robobun wants to merge 5 commits into
Open
install: reuse lockfile-resolved git/github/tarball packages when re-resolving#37142robobun wants to merge 5 commits into
robobun wants to merge 5 commits into
Claude / Claude Code Review
completed
Aug 7, 2026 in 29m 26s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/install/PackageManager/PackageManagerEnqueue.rs:644-652 |
Mirror site in bun.lock.rs not updated with alias fallback |
Annotations
Check warning on line 652 in src/install/PackageManager/PackageManagerEnqueue.rs
claude / Claude Code Review
Mirror site in bun.lock.rs not updated with alias fallback
nit: `resolve_peer_dep_version_based` in `src/install/lockfile/bun.lock.rs:3061-3075` computes `name_hash` from `dep.realname()` with a comment that it "Mirrors the realname hashing in `enqueue_dependency_with_main_and_success_fn`" — after this change the two sites diverge (the enqueue side now falls back to the alias when `realname()` is empty, this site does not). No runtime consequence — a miss there just returns `None` and the caller takes the path walk — but consider adding the same two-lin
Loading