install: remove files deleted from a folder dependency on reinstall with the isolated linker - #37138
Open
robobun wants to merge 4 commits into
Open
install: remove files deleted from a folder dependency on reinstall with the isolated linker#37138robobun wants to merge 4 commits into
robobun wants to merge 4 commits into
Claude / Claude Code Review
completed
Aug 7, 2026 in 16m 54s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/install/isolated_install/Installer.rs:918-926 |
debug_assert-only guard on a path that can degenerate to the project root |
Annotations
Check warning on line 926 in src/install/isolated_install/Installer.rs
claude / Claude Code Review
debug_assert-only guard on a path that can degenerate to the project root
The `debug_assert!` here compiles out in release builds, so the only thing preventing `delete_tree` from being called on the project root is the scheduling logic in `isolated_install.rs:2142-2150` (a different file). That invariant holds today, so this isn't a live bug — but if it's ever broken by a future refactor, the release binary would silently `rm -rf` the user's project instead of panicking. Consider upgrading to `assert!`, or explicitly skipping the delete when `append_store_path` append
Loading