install: fix isolated-linker deadlock installing patched git/github dependencies in workspaces - #37136
Closed
robobun wants to merge 5 commits into
Closed
install: fix isolated-linker deadlock installing patched git/github dependencies in workspaces#37136robobun wants to merge 5 commits into
robobun wants to merge 5 commits into
Claude / Claude Code Review
completed
Aug 7, 2026 in 16m 47s
Code review found 2 potential issues
Found 2 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/cli/install/isolated-install.test.ts:851 |
Explicit 90_000ms per-test timeout should be removed |
| 🟡 Nit | test/cli/install/isolated-install.test.ts:790-793 |
Test pipes stdout but never drains it |
Annotations
Check warning on line 851 in test/cli/install/isolated-install.test.ts
claude / Claude Code Review
Explicit 90_000ms per-test timeout should be removed
The explicit `90_000` per-test timeout should be removed — `test/CLAUDE.md` says "**CRITICAL**: Do not set a timeout on tests. Bun already has timeouts," and no other test in this file sets one. The PR description states the test runs in ~0.6s with the fix, so if the deadlock ever regresses a 90s ceiling only delays CI feedback compared to the file's default.
Check warning on line 793 in test/cli/install/isolated-install.test.ts
claude / Claude Code Review
Test pipes stdout but never drains it
The `install()` helper spawns with `stdout: "pipe"` but only drains `stderr` and awaits `exited` — `proc.stdout` is never read. Either add `proc.stdout.text()` to the `Promise.all` or drop `stdout: "pipe"` (REVIEW.md's "Subprocess tests: drain pipes concurrently" rule; every other spawn in this file that pipes stdout drains it).
Loading