usockets: keep the kernel poll registration in sync across us_poll_resize - #37098
Open
robobun wants to merge 8 commits into
Open
usockets: keep the kernel poll registration in sync across us_poll_resize#37098robobun wants to merge 8 commits into
robobun wants to merge 8 commits into
Claude / Claude Code Review
completed
Aug 7, 2026 in 14m 26s
Code review found 1 important issue
Found 1 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/net/socket.test.ts:681-691 |
Test hangs on failure: error/close events not wired to reject awaited promises |
Annotations
Check warning on line 691 in test/js/bun/net/socket.test.ts
claude / Claude Code Review
Test hangs on failure: error/close events not wired to reject awaited promises
nit: neither awaited promise here has a rejection path — `client.on("error", () => {})` swallows connect failures so the `connect` promise at line 688 never settles, and the server `close()`/`error()` no-ops mean `await ended` (line 691) hangs if the accepted socket dies before `end` fires. Per REVIEW.md ("Wire EVERY failure event … to reject the awaited promise"), consider `await new Promise<void>((resolve, reject) => { client.once("connect", resolve); client.once("error", reject); })` and havi
Loading