Skip to content

build: drop the MI_NO_SET_VMA_NAME define mimalloc never read #37080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 3 commits into from
Aug 7, 2026
Merged

build: drop the MI_NO_SET_VMA_NAME define mimalloc never read #37080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdb61a5
build: drop the MI_NO_SET_VMA_NAME define, which mimalloc never read
dylan-conway Aug 7, 2026
a9049b6
[autofix.ci] apply automated fixes
autofix-ci[bot] Aug 7, 2026
9f88393
Merge remote-tracking branch 'origin/main' into claude/drop-mi-no-set…
dylan-conway Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/bench-json-rust.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ build() {
if [ ! -f "$out" ] || [ "${*: -1}" -nt "$out" ]; then "$@" -o "$out"; fi
}
MI_FLAGS=(-O2 -fPIC -ftls-model=initial-exec -DNDEBUG -D_GNU_SOURCE -DMI_STATIC_LIB
-DMI_SKIP_COLLECT_ON_EXIT=1 -DMI_DEFAULT_ALLOW_THP=0 -DMI_NO_SET_VMA_NAME=1)
-DMI_SKIP_COLLECT_ON_EXIT=1 -DMI_DEFAULT_ALLOW_THP=0)
build "$SUP/mimalloc.o" $CC "${MI_FLAGS[@]}" -Ivendor/mimalloc/include -c vendor/mimalloc/src/static.c
build "$SUP/simdutf.o" $CXX -O3 -fPIC -std=c++20 -I"$SUP" -c "$SUP/simdutf.cpp"
build "$SUP/simdutf_shim.o" $CXX -O3 -fPIC -std=c++20 -I"$SUP" -c src/parsers/benches/support/simdutf_shim.cpp
Expand Down
9 changes: 0 additions & 9 deletions scripts/build/deps/mimalloc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,6 @@ export const mimalloc: Dependency = {
// memory cost isn't worth it. The cmake option only applies on Linux.
if (cfg.linux) defines.MI_DEFAULT_ALLOW_THP = 0;

// Skip prctl(PR_SET_VMA, PR_SET_VMA_ANON_NAME, ...) after each mmap.
// It needs CONFIG_ANON_VMA_NAME (5.17+); on kernels without it every
// call returns EINVAL — pure syscall overhead on the startup path.
// Whether the call is even compiled depends on whether the build
// toolchain's <sys/prctl.h> defines PR_SET_VMA, which made strace
// output diverge between toolchains. Disable it outright; the VMA
// label is debugging sugar we don't rely on.
if (cfg.linux) defines.MI_NO_SET_VMA_NAME = 1;

if (cfg.abi === "musl") defines.MI_LIBC_MUSL = 1;
if (override) defines.MI_MALLOC_OVERRIDE = true;

Expand Down