Worker / worker_threads: WebCore-shaped lifetimes, joined threads, one ordered VM teardown - #37075
Merged
Claude / Claude Code Review
completed
Aug 8, 2026 in 22m 18s
Code review found 2 potential issues
Found 1 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/bindings/ZigGlobalObject.h:789-791 |
Stale parentPort-mirroring doc + dead includes left by commit 3ff95aa |
Annotations
Check warning on line 791 in src/jsc/bindings/ZigGlobalObject.h
claude / Claude Code Review
Stale parentPort-mirroring doc + dead includes left by commit 3ff95aa7
Stale doc + dead includes left by commit 3ff95aa7: the `setNodeParentPort` doc here still says "Messages it dispatches are mirrored onto globalEventScope so the Web Worker style … keeps working under a node Worker" — the exact behavior 3ff95aa7 removed (its worker_threads.ts comment now says the opposite). Reword to "Registered so `start()` defers delivery until the entry has evaluated" (its remaining purpose per the commit message). Same commit also left `#include "MessagePort.h"` and `#include
Loading