Report failed promise settles in event-loop completions (subprocess, streams, blob, s3, valkey) - #37072
Open
robobun wants to merge 4 commits into
Open
Report failed promise settles in event-loop completions (subprocess, streams, blob, s3, valkey)#37072robobun wants to merge 4 commits into
robobun wants to merge 4 commits into
Claude / Claude Code Review
completed
Aug 6, 2026 in 26m 19s
Code review found 1 important issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | test/js/bun/io/bun-write.test.js:1003-1005 |
Pollution test's copyfile byte-count assertion breaks Windows self-rerun with uv_fs_copyfile disabled |
Annotations
Check failure on line 1005 in test/js/bun/io/bun-write.test.js
claude / Claude Code Review
Pollution test's copyfile byte-count assertion breaks Windows self-rerun with uv_fs_copyfile disabled
The `isWindows ? 0 : 7` assertion will fail in the Windows self-rerun triggered by the "Bun.write() without uv_fs_copyfile" test, which re-executes this file with `BUN_FEATURE_FLAG_DISABLE_UV_FS_COPYFILE=1`. Under that flag the copyfile completion routes through the read/write loop and resolves with the actual byte count (7), not 0, so the inner rerun fails and the outer `expect(await exited).toBe(0)` fails on Windows CI. Change the assertion to `isWindows && !IS_UV_FS_COPYFILE_DISABLED ? 0 : 7`
Loading