Report failed promise settles in event-loop completions (subprocess, streams, blob, s3, valkey) - #37072
Open
robobun wants to merge 4 commits into
Open
Report failed promise settles in event-loop completions (subprocess, streams, blob, s3, valkey)#37072robobun wants to merge 4 commits into
robobun wants to merge 4 commits into
Claude / Claude Code Review
completed
Aug 6, 2026 in 15m 46s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/io/bun-write.test.js:955 |
Test fixture leaks a temp directory on every run |
Annotations
Check warning on line 955 in test/js/bun/io/bun-write.test.js
claude / Claude Code Review
Test fixture leaks a temp directory on every run
The child fixture creates a temp directory via `fs.mkdtempSync(require("os").tmpdir() + "/bun-write-pollution-")` and writes three files into it, but never removes it — and the parent test has no handle to the path so it cannot clean up either. Every neighboring subprocess-fixture test in this file creates the directory in the parent via `using dir = tempDir(...)` and interpolates `String(dir)` into the fixture; this test should do the same (or add `fs.rmSync(dir, { recursive: true, force: true
Loading