console.takeHeapSnapshot: report snapshot parse failures instead of aborting - #37070
Open
robobun wants to merge 4 commits into
Open
console.takeHeapSnapshot: report snapshot parse failures instead of aborting#37070robobun wants to merge 4 commits into
robobun wants to merge 4 commits into
Claude / Claude Code Review
completed
Aug 6, 2026 in 21m 41s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/ConsoleObject.rs:6015-6025 |
takeHeapSnapshot: format-step exception still left pending |
Annotations
Check warning on line 6025 in src/jsc/ConsoleObject.rs
claude / Claude Code Review
takeHeapSnapshot: format-step exception still left pending
The new comment at lines 6017-6020 states that this function must not leave an exception pending because `consoleProtoFuncTakeHeapSnapshot` performs no exception check after the client call — but the very next call, `message_with_type_and_level(...)` at line 6028, can also throw (its wrapper explicitly leaves the exception pending on the VM), so the format step still hits the same failure mode the parse step just fixed. Consider calling `message_with_type_and_level_` directly and routing its `Er
Loading