bun:jsc: propagate JSONParse exceptions from samplingProfilerStackTraces - #37065
Open
robobun wants to merge 2 commits into
Open
bun:jsc: propagate JSONParse exceptions from samplingProfilerStackTraces#37065robobun wants to merge 2 commits into
robobun wants to merge 2 commits into
Claude / Claude Code Review
completed
Aug 6, 2026 in 11m 52s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/modules/BunJSCModule.h:501-503 |
Sibling site with identical JSONParse-then-releaseAssertNoException pattern left unfixed |
Annotations
Check warning on line 503 in src/jsc/modules/BunJSCModule.h
claude / Claude Code Review
Sibling site with identical JSONParse-then-releaseAssertNoException pattern left unfixed
One more sibling of this bug class remains: `JSC__JSGlobalObject__generateHeapSnapshot` at `src/jsc/bindings/bindings.cpp:3932-3935` still does `JSONParse(...)` → `scope.releaseAssertNoException()`, reachable via `console.takeHeapSnapshot()`. Per REVIEW.md's whole-class rule the same two-line fix (assert-before-parse, then `RELEASE_AND_RETURN` or plain return) belongs in this PR — heap snapshot JSON on a large heap is at least as OOM-prone as sampling-profiler JSON.
Loading